cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.15k stars 3.81k forks source link

opt: consider disabling stats when building reusable memo with placeholders #41792

Open rytaft opened 5 years ago

rytaft commented 5 years ago

Related to #41524.

As described in this comment, it may not be useful to calculate stats at all if we're building a memo with placeholders for reuse, since only normalization rules are applied at that stage. We'd still want to calculate stats and then clear the column stats for the no-placeholders case though, since the exec builder uses the row count.

cc @RaduBerinde

Jira issue: CRDB-5412

github-actions[bot] commented 3 years ago

We have marked this issue as stale because it has been inactive for 18 months. If this issue is still relevant, removing the stale label or adding a comment will keep it active. Otherwise, we'll close it in 5 days to keep the issue queue tidy. Thank you for your contribution to CockroachDB!

github-actions[bot] commented 1 year ago

We have marked this issue as stale because it has been inactive for 18 months. If this issue is still relevant, removing the stale label or adding a comment will keep it active. Otherwise, we'll close it in 10 days to keep the issue queue tidy. Thank you for your contribution to CockroachDB!

rytaft commented 11 months ago

still relevant