cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.1k stars 3.81k forks source link

ui: scrubbing timeseries charts results in poor performance with tooltips #45171

Closed piyush-singh closed 3 years ago

piyush-singh commented 4 years ago

As @dhartunian mentioned in #44836, scrubbing over a timeseries graph results in awkward stutters and lags due to how many different data points for which we are loading tooltips. One option to improve this is adding in a delay between mouse movement and tooltip loading. cc @Annebirzin

vladlos commented 4 years ago

@piyush-singh, researched this issue, to make long story short, current charting library doesn't provide any relevant api for configuration tooltips and lib itself can't handle amount of charts we show on one page. If this is really critical we can think about showing 1 chart per page. Or postpone it until we will be ready to change charting library.

piyush-singh commented 4 years ago

Vlad noted that the poor performance here is related to the total number of points displayed on a page. This means tooltip performance scales poorly with additional charts and more elements on the page. Vlad notes that > 300 elements on a page generally will result in poor browser performance.

leeoniya commented 4 years ago

allow me to plug uPlot, for fast timeseries graphs: https://github.com/leeoniya/uPlot

dhartunian commented 4 years ago

@leeoniya you'll be happy to hear we've already discussed possibly using uPlot internally :)

If we do end up pursuing a POC or put up a PR or anything I'll be sure to let you know.

leeoniya commented 4 years ago

neato, thanks!

thtruo commented 3 years ago

Closing as this was addressed in #63087