sql/opt: add implicit SELECT FOR UPDATE support for DELETE statements

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.

https://www.cockroachlabs.com

Other

30.04k stars 3.79k forks source link

sql/opt: add implicit SELECT FOR UPDATE support for DELETE statements #50181

Open nvanbenschoten opened 4 years ago

nvanbenschoten commented 4 years ago

Address this TODO:

https://github.com/cockroachdb/cockroach/blob/01a780bdc380d428611348a08aff301ae7c1938b/pkg/sql/opt/exec/execbuilder/mutation.go#L991-L999

Similar to https://github.com/cockroachdb/cockroach/issues/50180, but likely lower priority because sustained contending DELETEs don't seem to be as common, probably because once a row is deleted, it stays deleted and can't be deleted again.

Jira issue: CRDB-4147

rytaft commented 2 years ago

Is this a priority for 22.2?

michae2 commented 2 years ago

This might be a good one for @wenyihu6 if interested.

github-actions[bot] commented 9 months ago

We have marked this issue as stale because it has been inactive for 18 months. If this issue is still relevant, removing the stale label or adding a comment will keep it active. Otherwise, we'll close it in 10 days to keep the issue queue tidy. Thank you for your contribution to CockroachDB!