cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30k stars 3.79k forks source link

changefeedccl: don't use filepath.Join for network paths #59143

Open dt opened 3 years ago

dt commented 3 years ago
pkg/ccl/changefeedccl/encoder.go:489:   url.Path = filepath.Join(url.EscapedPath(), `subjects`, subject, `versions`)
pkg/ccl/changefeedccl/sink_cloudstorage.go:439: return s.es.WriteFile(ctx, filepath.Join(part, filename), bytes.NewReader(payload))
pkg/ccl/changefeedccl/sink_cloudstorage.go:533: return s.es.WriteFile(ctx, filepath.Join(s.dataFilePartition, filename), bytes.NewReader(file.buf.Bytes()))

Jira issue: CRDB-3331

blathers-crl[bot] commented 1 year ago

cc @cockroachdb/cdc