cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.07k stars 3.8k forks source link

teamcity: the Content-Type of log files is not properly set (any more?) #63483

Open knz opened 3 years ago

knz commented 3 years ago

This is a regression that occured some time in the past 2-3 months. @andreimatei first noticed it, and now I am noticing it too.

When I point my browser (Firefox) at a log file stored in artifacts, for example this: https://teamcity.cockroachdb.com/repository/download/Cockroach_UnitTests/2872605:id/acceptance/acceptance/logTestDockerCLI445411356/acceptancetest.gce-agent-ppr-20210401-preempt-79.agent.2021-04-12T15_12_39Z.011078.log

the server does not set a character-encoding in the HTTP headers.

This results in this: image

and this: image

This used (in the past) to be different.

All our log files are either ASCII or UTF-8. It would be useful to set Content-type: text/plain; charset=utf-8 on them.

cc @jlinder for triage.

Epic DEVINF-228

Jira issue: CRDB-6606

knz commented 3 years ago

@andreimatei here's a workaround I found

that will set the content encoding and then you can view your log file properly.

knz commented 3 years ago

Chrome is supposed to do auto-detection of the encoding but quite clearly it does not work :sweat:

dt commented 3 years ago

I don't think this is new just for the record / to save digging though TC history -- in safari at least, I've had garbled logs until I manually pick utf-8 each time ever since we added the non-ascii chars to logging.

github-actions[bot] commented 1 year ago

We have marked this issue as stale because it has been inactive for 18 months. If this issue is still relevant, removing the stale label or adding a comment will keep it active. Otherwise, we'll close it in 10 days to keep the issue queue tidy. Thank you for your contribution to CockroachDB!