opt: improve the code path for in-between spans

RaduBerinde commented 3 years ago

This issue tracks the problem discussed in https://github.com/cockroachdb/cockroach/pull/63932#issuecomment-823558935

We emit tuple inequalities for the "in-between" filters for a partitioning-directed index scan. Technically these filters are not correct when columns are nullable (because of NULL handling). They work currently (with special handling for the first column added in #63932) because of the way we generate index constraints for tuple inequalities.

Some possible solutions:

introduce a special tuple comparison operator which treats NULL as a regular, minimum value
don't synthesize real filter expressions; synthesize the spans directly and allow passing them to the index constraints code.

Jira issue: CRDB-6881

mgartner commented 3 years ago

I'm going to try to address this and get it out of the way while I have the context paged-in.

github-actions[bot] commented 11 months ago

We have marked this issue as stale because it has been inactive for 18 months. If this issue is still relevant, removing the stale label or adding a comment will keep it active. Otherwise, we'll close it in 10 days to keep the issue queue tidy. Thank you for your contribution to CockroachDB!

cockroachdb / cockroach

opt: improve the code path for in-between spans #64077