search

cockroachdb / cockroach

CockroachDB - the open source, cloud-native distributed SQL database.
https://www.cockroachlabs.com
Other
29.57k stars 3.71k forks source link

kvnemesis: add non-cooperative lease transfers #64829

Open nvanbenschoten opened 3 years ago

nvanbenschoten commented 3 years ago

We should extend kvnemesis to trigger non-cooperative lease transfers. This is split off from #64828 because it should be a lot easier to do. We can reach into node liveness and bump the liveness epoch of a node (while respecting expiration, somehow) to trigger non-cooperative lease transfers.

Jira issue: CRDB-7286

tbg commented 2 years ago

Is it that easy? We need to at least take the node down, right? Otherwise it can serve conflicting operations. Taking the node down until its liveness record is expired and then restarting it might be all that's needed here. Or are we trying to avoid the downtime? That would put us back into the game of bumping clocks, which is annoying, but maybe we can a) stop the node b) regress the liveness record's expiration to the lowest known-safe timestamp c) restart the node.

github-actions[bot] commented 10 months ago

We have marked this issue as stale because it has been inactive for 18 months. If this issue is still relevant, removing the stale label or adding a comment will keep it active. Otherwise, we'll close it in 10 days to keep the issue queue tidy. Thank you for your contribution to CockroachDB!