search

cockroachdb / cockroach

CockroachDB - the open source, cloud-native distributed SQL database.
https://www.cockroachlabs.com
Other
29.51k stars 3.7k forks source link

tracing: update the jaeger dependency #66081

Open knz opened 3 years ago

knz commented 3 years ago

Describe the problem

Snyk (our security analysis tool) has detected we are using an outdated version of github.com/jaegertracing/jaeger (v1.17.0) which has some potential security vulnerabilities.

However, when updating all the way to the latest version (v1.22), crdb doesn't build any more:

# github.com/cockroachdb/cockroach/pkg/util/tracing
pkg/util/tracing/shadow.go:44:12: undefined: zipkintracer.Collector
pkg/util/tracing/shadow.go:134:20: undefined: zipkintracer.NewHTTPCollector
pkg/util/tracing/shadow.go:136:3: undefined: zipkintracer.HTTPLogger
pkg/util/tracing/shadow.go:136:21: undefined: zipkintracer.LoggerFunc
pkg/util/tracing/shadow.go:151:14: undefined: zipkintracer.NewRecorder
pkg/util/tracing/shadow.go:154:19: undefined: zipkintracer.NewTracer
gmake: *** [Makefile:1026: cockroachshort] Error 2

The APIs have changed. The code should be updated to use the latest APIs.

To Reproduce

go get -u github.com/jaegertracing/jaeger
go mod tidy
make vendor_rebuild
make buildshort

cc @andreimatei @dhartunian

gz#10986

Jira issue: CRDB-7874

andreimatei commented 3 years ago

FWIW, the Zipkin dep will go away with #65599

knz commented 3 years ago

oh excellent. When will that one merge?

github-actions[bot] commented 10 months ago

We have marked this issue as stale because it has been inactive for 18 months. If this issue is still relevant, removing the stale label or adding a comment will keep it active. Otherwise, we'll close it in 10 days to keep the issue queue tidy. Thank you for your contribution to CockroachDB!