search

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.1k stars 3.81k forks source link

sql: highlight in the UI when stmt bundle collection is incomplete or failed #68523

Open yuzefovich opened 3 years ago

yuzefovich commented 3 years ago

Whenever a statement bundle collection is requested from the DB Console, it might result in a bundle that is incomplete. For example, this can happen when the user doesn't have the privileges for all things in the bundle (e.g. the user cannot read cluster settings). We should consider highlighting that somehow in the DB Console (perhaps a yellow icon somewhere). As of #105005 we are aggregating these non-critical errors into the errors.txt file in the bundle, but perhaps we'd need to expose it to the console differently.

Jira issue: CRDB-9067

kevin-v-ngo commented 3 years ago

@yuzefovich, can you provide more details on this issue? Did the user already have the MODIFYCLUSTERSETTING privilege?

yuzefovich commented 3 years ago

Unfortunately, I don't know any other details.

Perhaps @glennfawcett can check how we collected these stmt bundles during an escalation.

mgartner commented 2 years ago

I saw this again with a statement bundle from a CC cluster. We can try reproducing there. We should prioritize fixing this because it's preventing us from debugging customer issues.

yuzefovich commented 1 year ago

@kevin-v-ngo @maryliag I just updated the issue description with some more information. This issue is now about highlighting in the DB Console when there were some issues when collecting a bundle making that bundle incomplete. #105005 makes some improvements with the bundle itself as well as the output of EXPLAIN ANALYZE (DEBUG) in the SQL shell. It seems like it's now purely cluster o11y issue, so I'll remove from our board.

maryliag commented 1 year ago

@yuzefovich how can we identify that the bundle is incomplete? is there a specific flag or column value that we can check?

yuzefovich commented 1 year ago

That information is not currently stored in the system table explicitly - as of #105005 non-critical errors will be included into errors.txt file in the bundle. We'll need to expose the fact that the bundle is incomplete for DB Console, but it should be a pretty easy task.