search

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
29.89k stars 3.77k forks source link

sql: support inet data types #6981

Closed abh closed 6 years ago

abh commented 8 years ago

The inet and cidr data types in postgresql are very powerful for applications that deal with IP addresses; in particular IPv6 ones.

https://www.postgresql.org/docs/current/static/datatype-net-types.html https://www.postgresql.org/docs/current/static/functions-net.html

jordanlewis commented 7 years ago

This is required by a popular app that runs on Postgres - Mastodon.

nickjacques commented 7 years ago

+1, this is required for PowerDNS schema compatibility when using the postgresql backend.

dianasaur323 commented 7 years ago

adding @nstewart to the chain

aaomidi commented 7 years ago

This is absolutely required for any modern day application. It being open for more than a year with barely any updates is worrisome.

nstewart commented 7 years ago

This is on our radar and is scheduled to be part of the 1.2 release (mid-2018). We expect it to be in an alpha version of CockroachDB much earlier than that.

vivekmenezes commented 7 years ago

We are not adding CIDR support now until we find a need for it. Thanks!

aaomidi commented 6 years ago

What defines a need?

lgo commented 6 years ago

In the case of CIDR, if people bring up major projects that make use of that column specifically then I'd be more than happy to spend some time adding it. To my knowledge, CIDR is strictly less useful than INET as it seems to be a subset of INET. I'll be closing this as I've added the INET type and it's built-ins, but I created an issue to track the CIDR type, #18846.

I also didn't add many of the operators postgres supports for INET yet so there's another issue to track that, #18847. I didn't find the operators were in common use so I just didn't get around to it yet.

KempWatson commented 6 years ago

NetBox? Any modern cloud app (like, the apps that would want CRDB), would have good use for all three network datatypes.

knz commented 6 years ago

@KempWatson you're lucky I was running a random script on the github database to notice your comment. We don't see comments on closed issues otherwise. Please file a new issue if you find this important.