sql: include all session settings in statement bundle env.sql

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.

https://www.cockroachlabs.com

Other

29.86k stars 3.77k forks source link

sql: include all session settings in statement bundle env.sql #72434

Open mgartner opened 2 years ago

mgartner commented 2 years ago

We should include all session settings in the statement bundle so that we do not lack any information when debugging customer issues. If there are reasons why including all is problematic, we could consider including all session settings that do not have default values.

See the TODO here: https://github.com/cockroachdb/cockroach/blob/87f79da6ab14a27b6f4faa9e9a47bc88671686f7/pkg/sql/explain_bundle.go#L522-L523

Jira issue: CRDB-11151

Epic CRDB-14510

github-actions[bot] commented 6 months ago

We have marked this issue as stale because it has been inactive for 18 months. If this issue is still relevant, removing the stale label or adding a comment will keep it active. Otherwise, we'll close it in 10 days to keep the issue queue tidy. Thank you for your contribution to CockroachDB!