search

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.17k stars 3.82k forks source link

logs: telemetry logs are not properly excluding queries where application name starts with $ #72548

Open thtruo opened 3 years ago

thtruo commented 3 years ago

Problem was acknowledged by @knz - our telemetry logs are not properly excluding queries where the application name starts with a $ prefix.

cc @pransudash

Jira issue: CRDB-11201

Epic CRDB-32141

pransudash commented 3 years ago

Wondering if we should only be filtering out application names that start with $ internal since there are other shell apps that use the $ prefix. Here's a complete list of application names I'm seeing in logs today: 

$ internal-cockroach-cloud-automation
$ cockroach userfile
$ internal-cockroach-operator
$ cockroach import db
$ cockroach doctor
$ cockroach sql
$ cockroach dump
pransudash commented 3 years ago

@knz @thtruo is there any update or eta on this? It's affecting our ability to reliably report user queries. Let me know if I can help out anywhere

cc: @vilamurugu

knz commented 3 years ago

The issue is that using the $ sign is not reliable - we mix queries from various sources (both user and non-user) with that.

knz commented 3 years ago

Discussion on slack: https://cockroachlabs.slack.com/archives/C0159JK877C/p1623696396053600