search

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
29.9k stars 3.78k forks source link

Add avg_size stat to stats_tester.go and rerun stats quality tests #77020

Open rharding6373 opened 2 years ago

rharding6373 commented 2 years ago

The new table statistic avg_size is not fully reflected in the TPCC and TPCH stats quality tests. To do this, avg_size needs to be added to pkg/sql/opt/testutils/opttester/stats_tester.go like the other statistics, then the stats quality tests need to be run with the --rewrite-actual-stats flag.

The actual work to add avg_size to the stats_tester is anticipated to be small, but rerunning all the stats quality tests for every query will be time-consuming. Instructions on how to run the tests are here.

Jira issue: CRDB-13370

github-actions[bot] commented 1 year ago

We have marked this issue as stale because it has been inactive for 18 months. If this issue is still relevant, removing the stale label or adding a comment will keep it active. Otherwise, we'll close it in 10 days to keep the issue queue tidy. Thank you for your contribution to CockroachDB!