search

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
29.89k stars 3.77k forks source link

acceptance: acceptance tests should download prebuilt Docker images, not build them at test time #81405

Open rickystewart opened 2 years ago

rickystewart commented 2 years ago

Last week the acceptance test TestComposeGSSPython started failing with the following error:

        python_1     | psql: error: private key file "/certs/client.root.key" must be owned by the current user or root

This is because the postgresql-client apt package was updated to pull in a new version of postgres, including this change. With #81313 I worked around this by manually pulling in an older version of postgresql-client (postgresql-client-11) that does not have this behavior. This is a temporary workaround that doesn't actually address the root cause of the issue, which is that building docker images at test time may result in a test environment that we have never tested before and which is not guaranteed to actually work.

Instead we should build these docker images once and reference them via tag, as is typically done with docker. This will ensure that our test environments don't suddenly change under us.

Jira issue: CRDB-15204

github-actions[bot] commented 10 months ago

We have marked this issue as stale because it has been inactive for 18 months. If this issue is still relevant, removing the stale label or adding a comment will keep it active. Otherwise, we'll close it in 10 days to keep the issue queue tidy. Thank you for your contribution to CockroachDB!