cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
29.9k stars 3.78k forks source link

bench: ensure that benchmarks "work" under multi-tenancy #83461

Open yuzefovich opened 2 years ago

yuzefovich commented 2 years ago

As of #76582, we now use multi-tenant test setup in 50% of the tests, which includes the benchmarks. We probably forgot to consider the impact of that change on running the benchmarks, and there are a couple of things we need to address (quoting Raphael):

Separately, we need to make peace with the idea that single tenancy is going away. At some point in the future, we will transition all our bench tests to run on a multi-tenant cluster, and we are expecting no performance regression. If we are seeing a performance regression today, this means that there is multi-tenancy optimization work to do that needs to be planned and done by the appropriate teams.

As a quick fix, #83254 disabled the usage of the multi-tenant setup under bench.

Jira issue: CRDB-17081

Epic CRDB-31933

blathers-crl[bot] commented 11 months ago

cc @cockroachdb/test-eng