search

cockroachdb / cockroach

CockroachDB - the open source, cloud-native distributed SQL database.
https://www.cockroachlabs.com
Other
29.51k stars 3.7k forks source link

kvserver: reactively adjust paused replicas when overloaded stores set changes #84465

Open tbg opened 1 year ago

tbg commented 1 year ago

Is your feature request related to a problem? Please describe.

In the initial implementation of pausing followers, #84252, we pass the current set of overloaded followers to each unquiesced replica tick, and compute the set of followers to pause. This could be somewhat expensive.

Describe the solution you'd like

We should measure the overhead and if it is significant, switch to a system where we only recompute the pausing if there are material changes to the set of overloaded stores which have a follower on this replica.

Describe alternatives you've considered

Additional context

Related to #84252

Jira issue: CRDB-17674

blathers-crl[bot] commented 1 year ago

cc @cockroachdb/replication

github-actions[bot] commented 4 months ago

We have marked this issue as stale because it has been inactive for 18 months. If this issue is still relevant, removing the stale label or adding a comment will keep it active. Otherwise, we'll close it in 10 days to keep the issue queue tidy. Thank you for your contribution to CockroachDB!