search

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.04k stars 3.8k forks source link

sql: enable nightly tests in sqllogictest #84513

Open rytaft opened 2 years ago

rytaft commented 2 years ago

There are number of unused tests in the sqllogictest repo, as described in https://github.com/cockroachdb/sqllogictest/pull/5. Instead of deleting those tests, we should try to run them to increase test coverage of CockroachDB. There are a variety of reasons why we don't currently run these tests, some of which are explained in a comment in logic.go:

        // TODO(pmattis): Incompatibilities in numeric types.
        // For instance, we type SUM(int) as a decimal since all of our ints are
        // int64.
        // "/test/random/expr/*.test",

        // TODO(pmattis): We don't support unary + on strings.
        // "/test/index/random/*/*.test",
        // "/test/random/aggregates/*.test",
        // "/test/random/groupby/*.test",
        // "/test/random/select/*.test",

We should try to fix these incompatibilities if at all possible so we can start running them.

Jira issue: CRDB-17699

github-actions[bot] commented 9 months ago

We have marked this issue as stale because it has been inactive for 18 months. If this issue is still relevant, removing the stale label or adding a comment will keep it active. Otherwise, we'll close it in 10 days to keep the issue queue tidy. Thank you for your contribution to CockroachDB!