cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.2k stars 3.82k forks source link

admission: enable disk bandwidth bottleneck resource #86857

Open sumeerbhola opened 2 years ago

sumeerbhola commented 2 years ago

Followup to #82898 which created the basic infrastructure, configuration scheme, and did experimentation with regular and elastic kv0 traffic.

cc: @irfansharif @andrewbaptist

Jira issue: CRDB-18968

Epic: CRDB-37479

sumeerbhola commented 9 months ago

We should remember to also extend the disk bandwidth control to encompass disk writes of sstables due to incoming range snapshots.

jbowens commented 8 months ago

As a part of online restore, we'll need admission control to control downloading of external sstables so that we can download as fast as we can without affecting foreground workload latencies.

dshjoshi commented 2 months ago

@aadityasondhi @nicktrav Is this in progress or done or still in backlog? If it is in progress or done, can we update the status?

aadityasondhi commented 2 months ago

The functionality should be complete as of https://github.com/cockroachdb/cockroach/pull/129005.

The remaining work would be to:

The enable part means setting the cluster setting or store config flags for the provisioned bandwidth.