search

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.13k stars 3.81k forks source link

changefeedccl: granularly redact payload information in debug.zip #88935

Open amruss opened 2 years ago

amruss commented 2 years ago

In 22.2/22.1 patch release, we redacted the payloads from the system.jobs table for PCI compliance. This was a course-grained approach, that obscures important information for debugging. The cdc team should decide what information should not be redacted for changefeeds and implement this in a 22.2 patch release.

For more information, see: https://github.com/cockroachdb/cockroach/issues/88069 For inspiration, see: https://github.com/cockroachdb/cockroach/pull/87839

Jira issue: CRDB-20045

Epic CRDB-39822

blathers-crl[bot] commented 2 years ago

cc @cockroachdb/cdc

amruss commented 2 years ago

Hey @miretskiy can you look into this since you have the most experience with changefeed escalations? The need here is to decide what, if any, information we should not redact because it is important for debugging (and to decide the urgency of doing the unredaction)

miretskiy commented 1 year ago

Totally missed this issue; Not sure what information might be useful; I suppose any sort of escalations where debug.zip doesn't show basic info (tables, expressions, etc) would be pretty useless.

@amruss Do you think this is more generate jobs issue though?