search

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
29.86k stars 3.77k forks source link

dev: pkg/sql/parser/gen/y.output file not written on parsing failure #90067

Open mgartner opened 1 year ago

mgartner commented 1 year ago

Describe the problem

The pkg/sql/parser/gen/y.output is helpful in debugging changes to Our SQL YACC file, sql.y. When building with ./dev, this file is not written.

To Reproduce

  1. Edit pkg/sql/parser/sql.y with some invalid changes.
  2. Build with ./dev.
  3. Notice that pkg/sql/parser/gen/y.output does not exist.
  4. Build with make.
  5. Notice that pkg/sql/parser/gen/y.output does exist.

Jira issue: CRDB-20578 Epic CRDB-17171

rickystewart commented 1 year ago

Populating this file in the workspace after a failed build is probably a non-starter due to the sandbox. But we can cat this file if this build step fails, for example, so it's right in the terminal.

mgartner commented 1 year ago

It tends to be pretty large - I think the last one I saw was 12MB, so I'm not sure that printing it in the terminal will be useful.

mgartner commented 1 year ago

I'm also now less convinced of it's usefulness for debugging than when I originally posted this issue - it just failed to help me debug a shift/reduce conflict.

github-actions[bot] commented 4 months ago

We have marked this issue as stale because it has been inactive for 18 months. If this issue is still relevant, removing the stale label or adding a comment will keep it active. Otherwise, we'll close it in 10 days to keep the issue queue tidy. Thank you for your contribution to CockroachDB!