search

cockroachdb / cockroach

CockroachDB - the open source, cloud-native distributed SQL database.
https://www.cockroachlabs.com
Other
29.59k stars 3.71k forks source link

kvserver: no raft snaps should be necessary without log truncations #96198

Open tbg opened 1 year ago

tbg commented 1 year ago

See https://github.com/cockroachdb/cockroach/pull/87554 for discussion.

It should always be possible to add a voter without relying on the raft snapshot queue, assuming log truncations are disabled.

We're seeing that this isn't true, but only due to inefficiencies in the implementation.

This comment motivates and makes two suggestions:

Together they should achieve the stated goal, which the test in #87554 can help verify.

Jira issue: CRDB-23999

Epic CRDB-39898

blathers-crl[bot] commented 1 year ago

cc @cockroachdb/replication

andrewbaptist commented 1 year ago

Is this something that is likely to get into 23.1? It doesn't have any release/ga blocker tags on it? If you do I will wait on my TestDelegateSnapshot test #96841 and unskip it once this is fixed. Otherwise, I can look at alternatives to make that less flakey with the current behavior. Thanks!

tbg commented 1 year ago

Is this something that is likely to get into 23.1?

Sorry, missed this until just now. No, we're not going to get this into 23.1, apologies.