search

cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.18k stars 3.81k forks source link

kvserver: sep-raft-log: remove TODOEngine #97627

Open tbg opened 1 year ago

tbg commented 1 year ago

Each call to TODOEngine needs to either turn into StateEngine or LogEngine. Then we can remove TODOEngine

git grep -n -H -F 'TODOEngine()' | grep -Eo '^[^:]+:[0-9]+' | sed -E "s~^([^:]+):([0-9]+)~- [ ] https://github.com/cockroachdb/cockroach/blob/$(git rev-parse HEAD)/\1\#L\2~" | pbcopy
As of 2023-02-24 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/ccl/backupccl/full_cluster_backup_restore_test.go#L216 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/ccl/streamingccl/streamingest/replication_random_client_test.go#L315 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/ccl/streamingccl/streamingest/stream_ingestion_processor_test.go#L370 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/addressing_test.go#L172 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/batcheval/cmd_add_sstable_test.go#L1828 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/batcheval/knobs_use_range_tombstones_test.go#L54 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_merge_test.go#L201 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_merge_test.go#L224 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_merge_test.go#L358 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_merge_test.go#L752 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_merge_test.go#L1353 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_merge_test.go#L1371 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_merge_test.go#L2546 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_merge_test.go#L2547 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_merge_test.go#L3945 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_merge_test.go#L3946 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_merge_test.go#L4076 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_merge_test.go#L4077 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_merge_test.go#L5348 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_metrics_test.go#L305 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_raft_log_queue_test.go#L97 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_raft_test.go#L296 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_raft_test.go#L309 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_raft_test.go#L615 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_raft_test.go#L832 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_raft_test.go#L2970 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_raft_test.go#L5151 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_raft_test.go#L5159 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_raft_test.go#L5326 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_raft_test.go#L5379 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_raft_test.go#L5666 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_raft_test.go#L5807 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_raft_test.go#L5918 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_raft_test.go#L5923 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_raft_test.go#L5966 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_raft_test.go#L6017 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_replica_gc_test.go#L102 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_replica_test.go#L212 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_replica_test.go#L2824 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_replica_test.go#L3399 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_replica_test.go#L3467 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_replica_test.go#L3503 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_replica_test.go#L3550 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_replica_test.go#L3554 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_replica_test.go#L3650 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_replica_test.go#L3670 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_replica_test.go#L3757 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_replica_test.go#L5014 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_split_test.go#L229 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_split_test.go#L370 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_split_test.go#L386 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_split_test.go#L654 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_split_test.go#L673 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_split_test.go#L727 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_split_test.go#L732 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_split_test.go#L785 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_split_test.go#L793 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_split_test.go#L804 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_split_test.go#L855 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_split_test.go#L995 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_split_test.go#L1007 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_split_test.go#L1037 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_split_test.go#L1957 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_split_test.go#L2019 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_store_test.go#L94 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/client_store_test.go#L105 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/consistency_queue_test.go#L323 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/consistency_queue_test.go#L355 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/consistency_queue_test.go#L415 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/helpers_test.go#L90 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/intent_resolver_integration_test.go#L360 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/intent_resolver_integration_test.go#L393 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/intentresolver/intent_resolver_integration_test.go#L140 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/loqrecovery/collect_raft_log_test.go#L200 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/loqrecovery/server.go#L123 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/loqrecovery/server.go#L419 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/mvcc_gc_queue.go#L713 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/mvcc_gc_queue_test.go#L862 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/mvcc_gc_queue_test.go#L945 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/mvcc_gc_queue_test.go#L1197 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/mvcc_gc_queue_test.go#L1211 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/mvcc_gc_queue_test.go#L1294 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/raft_log_queue.go#L693 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/raft_log_queue_test.go#L340 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/raft_log_queue_test.go#L623 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/raft_log_queue_test.go#L918 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica.go#L1348 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica.go#L1359 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica.go#L1368 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica.go#L2002 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica.go#L2010 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica.go#L2271 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica.go#L2277 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_app_batch.go#L150 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_application_state_machine.go#L142 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_application_state_machine.go#L203 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_application_state_machine_test.go#L275 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_application_state_machine_test.go#L370 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_application_state_machine_test.go#L430 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_command.go#L326 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_command.go#L3115 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_consistency.go#L660 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_consistency.go#L743 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_consistency.go#L744 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_consistency.go#L783 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_corruption.go#L52 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_corruption.go#L53 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_corruption.go#L66 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_destroy.go#L114 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_destroy.go#L130 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_gossip.go#L97 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_init.go#L53 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_init.go#L146 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_init.go#L148 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_learner_test.go#L1977 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_raft.go#L959 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_raft.go#L2467 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_raftstorage.go#L66 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_raftstorage.go#L87 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_raftstorage.go#L111 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_raftstorage.go#L213 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_raftstorage.go#L537 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_raftstorage.go#L555 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_raftstorage.go#L567 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_raftstorage.go#L584 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_raftstorage.go#L684 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_rangefeed.go#L225 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_rangefeed.go#L391 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_read.go#L76 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_sideload_test.go#L187 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_sideload_test.go#L253 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_test.go#L220 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_test.go#L928 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_test.go#L4435 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_test.go#L4478 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_test.go#L4544 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_test.go#L4740 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_test.go#L4835 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_test.go#L7001 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_test.go#L13164 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_write.go#L558 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/replica_write.go#L701 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/split_queue_test.go#L102 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store.go#L1352 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store.go#L1795 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store.go#L1808 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store.go#L1871 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store.go#L1909 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store.go#L1919 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store.go#L2395 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store.go#L2412 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store.go#L2426 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store.go#L2568 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store.go#L2605 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store.go#L2611 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store.go#L2626 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store.go#L2970 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store.go#L2979 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store.go#L3040 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store.go#L3042 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store.go#L3060 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store.go#L3061 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store.go#L3065 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store.go#L3072 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store.go#L3576 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store_create_replica.go#L214 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store_pool_test.go#L250 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store_send.go#L354 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store_split.go#L249 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store_test.go#L463 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store_test.go#L476 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store_test.go#L547 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store_test.go#L842 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store_test.go#L1380 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store_test.go#L1691 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store_test.go#L2679 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/store_test.go#L4008 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/stores.go#L249 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/stores.go#L299 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/stores_server.go#L107 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/stores_server.go#L151 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/stores_server.go#L167 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/stores_server.go#L171 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/stores_test.go#L157 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/ts_maintenance_queue.go#L151 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/kv/kvserver/txn_wait_queue_test.go#L44 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/server/debug/replay/replay.go#L65 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/server/debug/replay/replay.go#L88 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/server/debug/replay/replay.go#L111 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/server/loss_of_quorum.go#L73 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/server/loss_of_quorum.go#L105 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/server/loss_of_quorum.go#L135 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/server/loss_of_quorum.go#L142 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/server/node.go#L631 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/server/node.go#L904 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/server/settings_cache_test.go#L89 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/server/span_stats_server.go#L149 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/server/span_stats_server.go#L176 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/server/status.go#L748 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/server/status.go#L3502 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/server/version_cluster_test.go#L323 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/sql/row/fetcher_mvcc_test.go#L152 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/sql/row/fetcher_mvcc_test.go#L166 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/sql/row/fetcher_mvcc_test.go#L178 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/sql/sem/builtins/fingerprint_builtin_test.go#L115 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/testutils/testcluster/testcluster.go#L1477 - [ ] https://github.com/cockroachdb/cockroach/blob/c0b2a17cf970a7273b82d2de105c8ae819ba0fd4/pkg/ts/db_test.go#L407

Epic: CRDB-220

Jira issue: CRDB-24795

blathers-crl[bot] commented 1 year ago

cc @cockroachdb/replication