cockroachdb / cockroach

CockroachDB — the cloud native, distributed SQL database designed for high availability, effortless scale, and control over data placement.
https://www.cockroachlabs.com
Other
30.11k stars 3.81k forks source link

dbconsole: add ability to filter per-store metrics #98059

Open kvoli opened 1 year ago

kvoli commented 1 year ago

Currently the DB Console UI allows filtering metrics by node. There is no way to filter metrics which are tagged by StoreID as well:

In the DB Console UI metrics dashboards:

image

In the DB Console UI advanced debug timeseries:

image

In _status/vars however, we do have access to metrics tagged per-store:

# HELP kv_allocator_load_based_replica_rebalancing_existing_not_overfull The number times the allocator determined that none of the range's replicas were on overfull stores
# TYPE kv_allocator_load_based_replica_rebalancing_existing_not_overfull counter
kv_allocator_load_based_replica_rebalancing_existing_not_overfull{store="1"} 0

This issue is to add support for filtering metrics per-store, similar to the way per-node currently works. Just having this filtering within the advanced debug metrics page would be sufficient.

Jira issue: CRDB-25057

Epic CRDB-41111

maryliag commented 1 year ago

cc @dongniwang

dshjoshi commented 1 week ago

@jbowens @nicktrav We already meet this requirement that is being asked in the description of this ticket - " Just having this filtering within the advanced debug metrics page would be sufficient" As can be seen in the screen capture below, Advanced debug Metric time series chart allows filtering by store. Screenshot 2024-10-28 at 2 13 35 PM

Can we close this?