cockroachdb / cockroachdb-cloudformation

Quickly setup dev/test CockroachDB clusters using AWS CloudFormation and Kubernetes
https://www.cockroachlabs.com/
Apache License 2.0
12 stars 4 forks source link

Flaky test: crashed pods may temporarily be "ready" on instantiation. #13

Closed nstewart closed 6 years ago

nstewart commented 6 years ago

A pod may be in the ready state temporarily but then crash moments later. We should ensure that the pod is ready for some period of time before we say "create complete".

asubiotto commented 6 years ago

I will work on this ASAP as part of fixing https://github.com/cockroachdb/cockroach/issues/22424. We need to split our liveness and readiness checks and make the readiness checks a bit more custom (check for draining status + ability to issue a SQL command like SELECT 1)

asubiotto commented 6 years ago

Fixed by https://github.com/cockroachdb/cockroach/pull/22911