PR #104265 - util/log: timezone support for formats crdb-v1 and crdb-v2 (2 of 3)

[cockroach-teamcity]

Exalate commented:

Related PR: https://github.com/cockroachdb/cockroach/pull/104265 Commit: https://github.com/cockroachdb/cockroach/commit/d756dec1b9d7245305ab706e68e2ec3de0e61ffc Fixes: CRDB-5594 CRDB-19901

---

Release note (cli change): The command cockroach debug merge-log was adapted to understand time zones in input files read with format crdb-v1 or crdb-v2.

Jira Issue: DOC-8102

[exalate-issue-sync[bot]]

Florence Morris (florence-crl) commented: Alex Barganier is looking into a possible bug, see [this slack thread](https://cockroachlabs.slack.com/archives/C06301L45NF/p1698849961871159?thread_ts=1698698681.802709&cid=C06301L45NF]

{quote}If timezones completely break debug merge-logs, that needs to be fixed.{quote}

Using v23.2.0-alpha.5 I ran a cluster with logs.yaml

{noformat}file-defaults: dir: /Users/florencemorris/local/1/logs format: crdb-v2 format-options: {timezone: america/new_york}{noformat}

I then created the attached debug.zip. After I unzipped it, I ran and got this error:

{noformat}$ ./cockroach debug merge-logs debug/nodes//logs/ ERROR: decoding on line 2: malformed log entry Failed running "debug merge-logs"{noformat}

[^debug1.zip)

[exalate-issue-sync[bot]]

Florence Morris (florence-crl) commented: From this slack thread,

{quote}I think this is a known issue where {{debug merge-logs}} isn't good at detecting the format of the logs that it's merging. If you specify the {{--format=crdb-v1}} flag, the {{merge-logs}} seems to work.

I believe this is known by TSE, and we have an issue outlining it here: https://github.com/cockroachdb/cockroach/issues/73374 Since {{merge-logs}} is an internal tool, and TSE can fix with a simple flag, we haven't put any time towards fixing it (I don't expect we will anytime soon)

…

But, I noticed that the command's docs don't even note the {{--format}} flag whatsoever... Maybe we can just note that the flag exists, and say that it's required?

…

I will add that the flag exists and say that it is required.{quote}