[DOC-10557] Fix LTS date logic bug and 23.1 TOC

mdlinville commented 3 months ago

These bugs are causing the unsupported-version admonition to show up only on Release pages and not in versioned pages for any version (including EOL).

Also add debug capability (disabled by default)
Also propagate the combined Releases TOC entry to 23.1

This PR takes over https://github.com/cockroachdb/docs/pull/18615 (which already had review) and implements its fixes, as well as fixing a regression I somehow introduced there and making the logic just a bit more safe. I keep missing the "In LTS maintenance or LTS assistance, just show the LTS assistance" message in the logic.

Previews

Versioned release pages: GA: https://deploy-preview-18667--cockroachdb-docs.netlify.app/docs/releases/v24.1 (No admonition) GA: https://deploy-preview-18667--cockroachdb-docs.netlify.app/docs/releases/v23.2 (No admonition) LTS: https://deploy-preview-18667--cockroachdb-docs.netlify.app/docs/releases/v23.1 (LTS admonition) EOL: https://deploy-preview-18667--cockroachdb-docs.netlify.app/docs/releases/v21.1 (EOL admonition)

Versioned non-release pages: GA: https://deploy-preview-18667--cockroachdb-docs.netlify.app/docs/v24.1/authentication (No admonition) GA: https://deploy-preview-18667--cockroachdb-docs.netlify.app/docs/v23.2/authentication (No admonition) LTS: https://deploy-preview-18667--cockroachdb-docs.netlify.app/docs/v23.1/authentication (LTS admonition) EOL: https://deploy-preview-18667--cockroachdb-docs.netlify.app/docs/v21.1/authentication (EOL admonition)

Unversioned pages: Homepage: https://deploy-preview-18667--cockroachdb-docs.netlify.app/docs/ (No admonition) Releases index: https://deploy-preview-18667--cockroachdb-docs.netlify.app/docs/releases/ (No admonition, LTS link in 23.1 table rows)

github-actions[bot] commented 3 months ago

Files changed:

src/current/_includes/sidebar-data-v23.1.json
src/current/_includes/unsupported-version.md
src/current/_includes/v23.1/sidebar-data/latest-releases.json
src/current/_layouts/page.html

netlify[bot] commented 3 months ago

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name	Link
Latest commit	ad40268da6679cc960265ca22ce1489a3acac983
Latest deploy log	https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/66720deb09a64f000883ed3f

netlify[bot] commented 3 months ago

Deploy Preview for cockroachdb-api-docs canceled.

Name	Link
Latest commit	ad40268da6679cc960265ca22ce1489a3acac983
Latest deploy log	https://app.netlify.com/sites/cockroachdb-api-docs/deploys/66720debe41cee0008e6ea25

netlify[bot] commented 3 months ago

Netlify Preview

Name	Link
Latest commit	ad40268da6679cc960265ca22ce1489a3acac983
Latest deploy log	https://app.netlify.com/sites/cockroachdb-docs/deploys/66720deb606c180008211e96
Deploy Preview	https://deploy-preview-18667--cockroachdb-docs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cockroachdb / docs