cockroachdb / docs

CockroachDB user documentation
https://cockroachlabs.com/docs
Creative Commons Attribution 4.0 International
190 stars 460 forks source link

Rename "Core" to "Basic" changefeeds #19072

Closed rmloveland closed 3 weeks ago

rmloveland commented 3 weeks ago

Addresses DOC-10665

Summary of changes:

github-actions[bot] commented 3 weeks ago

Files changed:

netlify[bot] commented 3 weeks ago

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
Latest commit e4ba7d336276a5d34589106c98861eb8b585a7c2
Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/6728f6115e8ecf0008ca3bcb
netlify[bot] commented 3 weeks ago

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
Latest commit e4ba7d336276a5d34589106c98861eb8b585a7c2
Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/6728f6119c37e8000860e194
rmloveland commented 3 weeks ago

@rohan-joshi and @jaiayu IMO y'all are optional on actually reviewing this but I wanted to keep you informed of the change

it's a pretty straightforward find and replace

@kathancox pls take a look as the docs maintainer of this stuff and make sure I didn't mess up anything with my mostly blind find and replace :-)

netlify[bot] commented 3 weeks ago

Netlify Preview

Name Link
Latest commit e4ba7d336276a5d34589106c98861eb8b585a7c2
Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/6728f611617aaf0008b1c0d0
Deploy Preview https://deploy-preview-19072--cockroachdb-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rmloveland commented 3 weeks ago

I'll wait for @rohan-joshi to confirm this is ok for now.

FWIW Rohan confirmed in a DM with me and Ayushi, i can't share a link but i noted it in this Jira comment

My opinion is that we're approaching the release very quickly, and so this should work as a stop gap.

🚀 🙏

Thanks for the review Kathryn! I believe i've fixed all the capitalization errors in the latest commit named Update with kathancox feedback (1)

rohan-joshi commented 3 weeks ago

lgtm, thanks all