cockroachdb / errors

Go error library with error portability over the network
Apache License 2.0
2.04k stars 66 forks source link

Gogoprotobuf replacement #138

Open jdmeyer3 opened 3 months ago

jdmeyer3 commented 3 months ago

Since gogo/protobuf has been deprecated since January of 2021, are there any thoughts on replacing it with any other protocol buffer library or simply using the vanilla golang protobuf library?

This has been brought up in earlier discussions (#80)

rsc commented 2 weeks ago

I am running into this too, with errors as a dependency of pebble. Bringing in gogo/protobuf brings in references to very old other packages that I can't eliminate. The normal way to eliminate them would be to get gogo/protobuf to update their dependencies, but gogo/protobuf is deprecated so they're not doing updates.

It seems like for this usage, the ordinary Go protobuf library should be fine.

pqn commented 1 week ago

In case it's useful, I've just started a fork to attempt to remove it. I wasn't really concerned about migrating the gRPC middleware for my use case, so I just deleted it: https://github.com/cockroachdb/errors/compare/v1.11.3...Exafunction:errors:exa-v1.11.3

The same set of tests that passes in the latest release tag also passes, but I've yet to test with our real services.