Closed yuzefovich closed 4 years ago
Thank you!
For clarity, can you copy-paste a screenshot of a sentry report generated with the new code?
cc @tooolbox - I wasn't expected we'd invest in this so soon, but here you are.
I ran the test with DSN
specified as cockroachdb
project, and here is what I got:
(The link to the event)
Thank you this looks good overall. However I'd like to see how this impacts the reporting of SQL errors. I would recommend to operate as follows:
rm -rf vendor/github.com/cockroachdb/errors
crdb_internal.force_error('XX000', 'woops')
Is the SQL statement included? Is it clear from the sentry message that the error was generated with force_error
?
If yes then this is good to go.
Thanks for the pointers!
I made some modifications to cockroach
to use sentry-go
as well, and here is the report
(and the link)
I think it looks good, right?
Oh yeah that looks awesome. LGTM!
After you merge this we need to bump the version because this is a backward-incompatible API change. You can add a tag for v1.3
.
TFTR!
I'll push a new tag momentarily.
Previously, we were using getsentry/raven-go to populate the reports for Sentry. However, that tool has become obsolete. This commit switches to using getsentry/sentry-go.
There are some differences in the API, and I made the following changes:
This change is