search

cockroachdb / errors

Go error library with error portability over the network
Apache License 2.0
2.08k stars 66 forks source link

Requires use of github.com/cockroachdb/sentry-go #36

Closed mikesun closed 2 years ago

mikesun commented 4 years ago

This package uses its own fork of sentry-go which means a user of this package has to use the forked version when initializing the sentry client. Is that the accepted practice around this?

knz commented 4 years ago

I don't know what the accepted practice is. Do you have a better suggestion?

jhchabran commented 2 years ago

Hello @knz, I was checking the dependencies in one of the projects I work on, spotted the old sentry-go version and ended up here.

Seeing this diff my best guess is that on some occasions, it has been useful to jump ahead and pin the dependencies at on a specific commit on the master branch.

Would you want something done about it?

  1. Drop the fork and update errors to use directly getsentry/sentry-go
  2. Keep the fork, but just update it, as mentioned in #41, just going up to v0.11.0.
  3. Something else?

Reading through their changelog, there are no mentions of any breaking changes.