search

cockroachdb / errors

Go error library with error portability over the network
Apache License 2.0
2.07k stars 66 forks source link

Tweak import paths of .proto files in errorspb #60

Closed rickystewart closed 3 years ago

rickystewart commented 3 years ago

This makes imports consistent both within this repository as well as in the main CockroachDB repo. This simplifies the Bazel migration as seen in https://github.com/cockroachdb/cockroach/pull/57974.

This change is Reviewable

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

knz commented 3 years ago

LGTM thanks

tooolbox commented 3 years ago

Out of curiosity, is this change backwards compatible, i.e. markers encoded with the old registered name will properly decode with the new registered name, and vice versa?

rickystewart commented 3 years ago

To my knowledge, yes (and this change has been live at CockroachDB master for more than 2 weeks, so I imagine that any issues would have been noticed by now).

knz commented 3 years ago

markers encoded with the old registered name will properly decode with the new registered name, and vice versa?

Thanks for noticing. I agree we need to explicitly check this.

I imagine that any issues would have been noticed by now).

No not necessarily. Last time we broke something in that area, we only noticed when a customer encountered a production outage after an upgrade :sob:

knz commented 3 years ago

@rickystewart also you don't need to do anything about this; I will do the investigation and fix the fallout if any.