search

cockroachdb / errors

Go error library with error portability over the network
Apache License 2.0
2.07k stars 66 forks source link

Investigate whether there is fallout from #60 #61

Closed knz closed 3 years ago

knz commented 3 years ago

@tooolbox pointed out helpfully that #60 may have changed the protobuf package paths and thus the encoding of errors over the network.

This needs to be checked in a test. If there is any discrepancy, that needs to be dealt with a proper RegisterTypeMigration call.

knz commented 3 years ago

I have investigated this by looking at the binary protobuf encoding of test errors.

The protobuf package path is unchanged and remains cockroachdb.errorspb. There is no change in the binary encoding. So #60 does not require any change in apps.

Thanks @tooolbox for asking nevertheless.

tooolbox commented 3 years ago

No problem, thanks for checking it out!