search

cockroachdb / errors

Go error library with error portability over the network
Apache License 2.0
2.07k stars 66 forks source link

Update to gogoproto 1.3. #67

Closed knz closed 3 years ago

knz commented 3 years ago

This change is Reviewable

knz commented 3 years ago

Could we somehow lock these versions in go.mod, even though they're build tools rather than direct dependencies?

Maybe; how should I do this?

erikgrinaker commented 3 years ago

Maybe; how should I do this?

You could do something like this: https://marcofranssen.nl/manage-go-tools-via-go-modules/

The Go team approves: https://github.com/golang/go/issues/25922#issuecomment-402918061

erikgrinaker commented 3 years ago

Also, I seem to recall that @tooolbox had some ideas on handling build-time dependencies.

knz commented 3 years ago

Rebased; also:

Could we somehow lock these versions in go.mod, even though they're build tools rather than direct dependencies?

In fact, not yet. I had to revert that doc change in the Makefile - for now, we still prefer to use crdb's own protoc-gen-gogo to ensure that the generated structs are simplified.

So that point is not yet relevant.

erikgrinaker commented 3 years ago

Cool, let's revisit later.