search

cockroachdb / errors

Go error library with error portability over the network
Apache License 2.0
2.07k stars 66 forks source link

Verify "go mod tidy" in CI #81

Closed kernfeld-cockroach closed 3 years ago

kernfeld-cockroach commented 3 years ago

Previously, there was no verification that it was possible to run "go mod tidy" and "go mod vendor" in projects that depend on errors. This commit adds a CI step to check that these "go mod" commands can run successfully.

This change is Reviewable

knz commented 3 years ago

this needs an exception for 1.13 and 1.14

kernfeld-cockroach commented 3 years ago

this needs an exception for 1.13 and 1.14

I think you're saying that we shouldn't try to run go mod tidy on 1.13 and 1.14. Do you have a suggestion for implementing this? Maybe a little bash check in ci.yaml?

knz commented 3 years ago

yeah that's what I had in mind, a shell conditional in front of the go mod tidy command

kernfeld-cockroach commented 3 years ago

I added the exception and a disclaimer in the README about "go mod tidy" and "go mod vendor."