cockroachdb / helm-charts

Helm charts for cockroachdb
Apache License 2.0
85 stars 148 forks source link

Add the "client-secure" Pod to the Helm chart? #382

Open roy-work opened 8 months ago

roy-work commented 8 months ago

Is your feature request related to a problem? Please describe. It would be nice to have an easy way to connect to the CRDB cluster in a Kubernetes cluster.

Describe the solution you'd like The docs even note this as a thing you might want to do, and link you to the almost ready-made example of how to create a pod to do that: https://github.com/cockroachdb/cockroach/blob/master/cloud/kubernetes/client-secure.yaml

Can that just make its way into the Helm chart? (It would be fine, and perhaps preferable, if that was being a values.yaml flag to enable/disable it, too.)

I'd also switch this from a raw Pod (which isn't recommended, and has various downsides) to a Deployment¹ with replicas: 1. sleep (at least the one that is in GNU coreutils) can be invoked as sleep infinity, and dumb-init will all the pod to shutdown gracefully; a minimal "do nothing" pod is dumb-init -- sleep infinity, and then you don't need the terminationGradePeriod directive.

Describe alternatives you've considered

The status quo, of having it as an example:

Additional context ¹This does have the downside of making the pod name ugly. A StatefulSet would make the pod name nicer, unless there's some magic way with a Deployment to do nice names that I don't know about.

Jira issue: CRDB-36686

blathers-crl[bot] commented 8 months ago

Hello, I am Blathers. I am here to help you get the issue triaged.

I was unable to automatically find someone to ping.

If we have not gotten back to your issue within a few business days, you can try the following:

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.