Closed siennathesane closed 1 year ago
@mxplusb I just tried building this PR and got the following error, are one of the dependencies not constrained?
#12 6.902 go: finding module for package github.com/googleapis/gnostic/OpenAPIv2
#12 7.176 /go/pkg/mod/k8s.io/client-go@v0.18.6/discovery/discovery_client.go:30:2: module github.com/googleapis/gnostic@latest found (v0.5.1), but does not contain package github.com/googleapis/gnostic/OpenAPIv2
Looks like it could be related to https://github.com/googleapis/gnostic/issues/156
Update:
I have confirmed that running go get github.com/googleapis/gnostic@v0.4.0
fixes the build issue
@jrote1 it looks like it was a transitive dependency, I locked the dependency and pushed, should be good.
This brings the request-cert dependencies up to supported versions, and fixes the signing process so the Kubernetes CSR APIs will auto-provision certificates. Currently, the tool does not auto-provision the certificates once they've been approved, and following the installation instructions does not work. I verified this by following the steps in the installation instructions and I can verify the CSRs were provisioned properly and the cluster does start. I also verified the secure client implementation works as well, I've attached a screenshot.
There are still some concerns I've raised in cockroachdb/cockroach#52418, so if that gets implemented, then applying the fix here is now trivial.
Signed-off-by: Mike Lloyd mlloyd@rts.com