search

cockroachdb / k8s

Images and utilities to run cockroach on kubernetes
Apache License 2.0
26 stars 25 forks source link

locality-checker: switch from positional parameter to -dest flag #35

Closed jreut closed 3 years ago

jreut commented 3 years ago

Previously, using the locality-checker like this:

locality-checker /etc/cockroach-env --prefix=aws-

caused this error:

error writing locality: open --prefix=aws-/region: no such file or directory

This patch fixes a positional parameter parsing bug by using only flag parameters.

This change is Reviewable

jreut commented 3 years ago

TFTR! We should also note to all our selves that we need to change the command lines when deploying this change.