cockroachdb / loadgen

CockroachDB load generators
Apache License 2.0
30 stars 25 forks source link

handle 1.x and 2.x information_schema #162

Closed robert-s-lee closed 6 years ago

robert-s-lee commented 6 years ago

correctly handle schema introspection of CRDB 1.x and CRDB 2.0

previous information_schema introspection for schema and primary key used 1.x convention (below) of hardcoded 'def'. Adjustment was made to check for 2.x convention as well.

version table_catalog table_schema table_name
1.x def dbName tableName
2.x dbName public tableName
cockroach-teamcity commented 6 years ago

This change is Reviewable

jordanlewis commented 6 years ago
:lgtm:

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

robert-s-lee commented 6 years ago

@jordanlewis can you help me. not sure what the process to fix the below

[16:44:28][Step 2/3] fatal: could not create work tree dir '/home/agent/work/.go/src/github.com/cockroachdb/go-test-teamcity': Permission denied