search

cockroachdb / loadgen

CockroachDB load generators
Apache License 2.0
30 stars 25 forks source link

tpcc: add more checks #165

Closed rjnn closed 6 years ago

rjnn commented 6 years ago

Added 3.3.2.7, 3.3.2.8, 3.3.2.9.

cockroach-teamcity commented 6 years ago

This change is Reviewable

jordanlewis commented 6 years ago

Will review again when you've added the intent of the checks

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, 1 unresolved discussion.

tpcc/check.go, line 229 at r1 (raw file):


func check3327(db *sql.DB) error {

Please summarize the condition that the checks are testing, along with their section number like the other checks. Also, that will help with the review as currently it's hard to tell what the intent of each query is.

Comments from Reviewable

rjnn commented 6 years ago

Done. PTAL.

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

tpcc/check.go, line 229 at r1 (raw file):

Previously, jordanlewis (Jordan Lewis) wrote…
Please summarize the condition that the checks are testing, along with their section number like the other checks. Also, that will help with the review as currently it's hard to tell what the intent of each query is.

Done.

Comments from Reviewable

jordanlewis commented 6 years ago
:lgtm:

Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable