internal/metamorphic: use a ValueMerger that may delete

cockroachdb / pebble

RocksDB/LevelDB inspired key-value database in Go

BSD 3-Clause "New" or "Revised" License

4.66k stars 430 forks source link

internal/metamorphic: use a ValueMerger that may delete #1429

Open jbowens opened 2 years ago

jbowens commented 2 years ago

Since b4d64c6474a2e0203a1ac2413dca90bdf74f4981 ValueMergers have been capable of deleting keys. There are some subtleties within the iterator to accommodate this, and it would be good to exercise them in the metamorphic tests (even if CockroachDB doesn't ever delete keys from a ValueMerger).

Jira issue: PEBBLE-111

github-actions[bot] commented 1 year ago

We have marked this issue as stale because it has been inactive for 18 months. If this issue is still relevant, removing the stale label or adding a comment will keep it active. Otherwise, we'll close it in 10 days to keep the issue queue tidy. Thank you for your contribution to Pebble!