search

cockroachdb / pebble

RocksDB/LevelDB inspired key-value database in Go
BSD 3-Clause "New" or "Revised" License
4.81k stars 448 forks source link

replay: change findManifestFile test to not use binary data #2201

Closed coolcom200 closed 2 months ago

coolcom200 commented 1 year ago

Currently the replay/testdata/corpus/findManifestStart test constructs part of a manifest using binary data which is difficult to understand and debug. Thus, change this test to use a programmatically generated manifest and use it for the test.

Related to: https://github.com/cockroachdb/pebble/pull/2152#pullrequestreview-1201291860

Jira issue: PEBBLE-163

github-actions[bot] commented 3 months ago

We have marked this issue as stale because it has been inactive for 18 months. If this issue is still relevant, removing the stale label or adding a comment will keep it active. Otherwise, we'll close it in 10 days to keep the issue queue tidy. Thank you for your contribution to Pebble!