db: delay deletion of WALs at Open

cockroachdb / pebble

RocksDB/LevelDB inspired key-value database in Go

BSD 3-Clause "New" or "Revised" License

4.66k stars 430 forks source link

db: delay deletion of WALs at Open #2617

Open jbowens opened 1 year ago

jbowens commented 1 year ago

During Open we replay old WALs and promptly delete them. This limits our ability to debug issues with corruption at the tail of the WAL. We could consider delaying the deletion of existing WALs (or files in general) until some fixed time after the database has opened.

Linking to cockroachlabs/support#2369.

Jira issue: PEBBLE-43

Epic CRDB-40360

jbowens commented 1 year ago

The same treatment ideally would be applied to the CockroachDB encryption-at-rest file registry.