Open jbowens opened 6 days ago
Ditto on the nice find! Is the speedup also present on Arm? Did you also look at decompression speed?
There's an issue here that the library doesn't seem to produce the same output on all platforms, and our tests depend on determinism of compression across platforms. I will return to this and try to dig a little deeper to where the platform dependence is coming from—it seems surprising and undesirable.
Interesting.. What platform did you use to generate them? If it was MacOS, I would expect the go-macos
test to pass and others to fail?
Yeah, I generated locally on my arm mac. I think it must be arch dependent, and the go-macos action uses an intel mac
Use the github.com/klauspost/compress module's Snappy implementation. It's faster (10-20%) and generates comparable compressed sizes. Although it obeys the same format as Snappy and is bi-directionally compatible with Google's Snappy implementation, it does not produce identical payloads (claiming to produce slightly smaller payloads).