cockroachdb / pebble

RocksDB/LevelDB inspired key-value database in Go
BSD 3-Clause "New" or "Revised" License
4.6k stars 424 forks source link

sstable: fix a few lint issues #3705

Closed jbowens closed 5 days ago

jbowens commented 5 days ago

Fix a few lint issues, like an unused parameter and a few ineffective nil checks.

cockroach-teamcity commented 5 days ago

This change is Reviewable

jbowens commented 5 days ago

TFTR!

RaduBerinde commented 5 days ago

sstable/suffix_rewriter.go line 493 at r1 (raw file):

          return nil, err
      }
      w.addPoint(scratch, val, false)

Why did we strip out the error check?