cockroachdb / pebble

RocksDB/LevelDB inspired key-value database in Go
BSD 3-Clause "New" or "Revised" License
4.97k stars 458 forks source link

reduce severity for 'pebble: compaction cancelled by a concurrent operation, will retry compaction' #3938

Open tbg opened 2 months ago

tbg commented 2 months ago

Have been seeing these regularly recently:

teamcity-16884024-1726292891-120-n7cpu4-0005> E240914 12:20:44.318336 17340 3@pebble/event.go:764 ⋮ [T1,n5,s5,pebble] 255 background error: pebble: compaction cancelled by a concurrent operation, will retry compaction

Apparently they are expected^1, so they should likely be logged as informational, if at all.

Jira issue: PEBBLE-257

RaduBerinde commented 2 months ago

We should instead expose some metrics about how much work was wasted (eg bytes written in canceled compactions).