search

cockroachdb / pebble

RocksDB/LevelDB inspired key-value database in Go
BSD 3-Clause "New" or "Revised" License
4.94k stars 458 forks source link

rowblk: move unsafe_test.go from sstable #4171

Closed jbowens closed 1 week ago

jbowens commented 1 week ago

The unit tests in unsafe_test.go were vestiges from when the rowblk implementation was in the sstable package. The sstable package versions of these functions (getBytes and decodeVarint) were unused outside of tests. This commit moves these unit tests into the rowblk package where they exercise the versions of these functions that are actually in use, and removes the unused sstable package funcs.

cockroach-teamcity commented 1 week ago

This change is Reviewable

jbowens commented 1 week ago

TFTR!