Update Artifact action to v4

cockroachdb / replicator

replicator is a toolkit for ingesting logical replication feeds into a CockroachDB cluster

Apache License 2.0

60 stars 24 forks source link

Open rail opened 6 days ago

rail commented 6 days ago

Fixes: DEVINF-1334

This change is

bobvawter commented 6 days ago

Tests don't pass.

rail commented 6 days ago

Tests don't pass.

Ooooh, looks like they changed the action behavior.

rail commented 6 days ago

Looks like the name should be unique. We need to append something using ${{ matrix.xxx }}. Any suggestions?

Jeremyyang920 commented 3 days ago

Looks like the name should be unique. We need to append something using ${{ matrix.xxx }}. Any suggestions?

I don't have a real suggestion, Maybe whatever the source DB was but not sure if that ends up being unique right now. cc @ryanluu12345

rail commented 3 days ago

Hmm, actually this may be a bit more complicated. The download step should collect all uploaded artifacts. 🤔