search

cockroachdb / sequelize-cockroachdb

Use Sequelize and CockroachDB together
Apache License 2.0
53 stars 16 forks source link

Fix model geometry test #115

Closed dougmrqs closed 3 years ago

dougmrqs commented 3 years ago

Known issue #52. Also cockroach #21286.

Rewrote the test suite to expect CRS. Also patched to explicitly cast the field as JSON.

RichardJCai commented 3 years ago

Hey @rafiss, can you take a look at what if I did here was sane in regards to skipping tests. Specifically here: https://github.com/cockroachdb/sequelize-cockroachdb/pull/115/files#diff-f5c2a3a9df2cc87861ec22f58c64e742d83690095f17d368e164aee348fe572bR13

I drew inspiration from https://stackoverflow.com/questions/32723167/how-to-programmatically-skip-a-test-in-mocha but I'm not great with JS.

rafiss commented 3 years ago

when you merge it in, i'd recommend doing "squash and merge"