search

cockroachdb / sequelize-cockroachdb

Use Sequelize and CockroachDB together
Apache License 2.0
53 stars 16 forks source link

Fix sync integration test #56

Closed douglasselias closed 3 years ago

douglasselias commented 3 years ago

@rafiss @RichardJCai

Fix sequelize sync test by patching the describe table function

Note: there is one test that is skipped because it gives a error when coverting a existing column to another type, which cockroachdb doesn't support yet.

douglasselias commented 3 years ago

I think it's doable, mochajs has a grep CLI option to pass a string or regex and a invert option for the grep match. It would look like this: mocha --grep "test name to skip" --invert

About the tests fork. It's more convenient to run locally in case we need to fix something else in the test. Also it would be only the failing tests we would need to fork. I think in this initial phase we can fork them and when we solve all the bugs, we remove them.

douglasselias commented 3 years ago

One test is skipped because of this error: "unimplemented: ALTER COLUMN TYPE from int to varchar is prohibited until v21.1" Cockroach doesn't have support for altering the existing column type yet, only in version 21.1.

douglasselias commented 3 years ago

After reabasing with master it popped up new bugs but only when executing all tests locally, so I skipped some more tests. All patches still works in the integration tests from sequelize.