cockroachdb / sequelize-cockroachdb

Use Sequelize and CockroachDB together
Apache License 2.0
53 stars 16 forks source link

Improve tests and allow BigInts on `findByPk` #65

Closed papb closed 3 years ago

papb commented 3 years ago

Hello! :smiley:

This PR does several things:


You can see the new [[skip sequelize integration tests]] feature working at my fork (once this PR is merged, it will start being applied on this repo automatically) - it only has 2 checks instead of over 200. This is great for faster feedback and for saving energy, for situations in which we don't really want to see all those checks (which is exactly the case for this PR, since I didn't change anything that I expect to make a difference on those results).


Suggestion: I think an admin of this repository should set the two "main" checks as required for merges (at some point, perhaps not now while many changes are still being done):

This can be done in the Require status checks to pass before merging section, here:

image

vy-ton commented 3 years ago

@RichardJCai Pedro (@papb) was the Sequelize maintainer we were first working with. This is his final PR with some improvements that he shared. Can you help merge this work with the ongoing work from our other contractors?

RichardJCai commented 3 years ago

@RichardJCai Pedro (@papb) was the Sequelize maintainer we were first working with. This is his final PR with some improvements that he shared. Can you help merge this work with the ongoing work from our other contractors?

Ack, will do.

RichardJCai commented 3 years ago

LGTM thanks!